search

kontron / python-ipmi

A pure python IPMI library
GNU Lesser General Public License v2.1
187 stars 74 forks source link

Fix parsing of maximum current output in power module capability record #98

Closed EmilioPeJu closed 2 years ago

hthiery commented 2 years ago

Hi, thanks for that fix. Do you have an example fru binary file that we could include for unit testing?

EmilioPeJu commented 2 years ago

Done, the unit test uses FRU data from a power module

hthiery commented 2 years ago

Looks good so far. Would you please add your "Signed-off-by" tag.

EmilioPeJu commented 2 years ago

Done

mwalle commented 2 years ago

Am 2021-10-04 10:52, schrieb Emilio PJ:

I think I added the sign-off-by tag but it doesn't contain a signature, is that OK for you? or do you also require the commit to have the GPG signature?

No, only your SoB is needed. No need for a GPG signature.

-michael

EmilioPeJu commented 2 years ago

Thanks for clarifying