konveyor-ecosystem / kai

Konveyor AI - static code analysis driven migration to new targets via Generative AI
Apache License 2.0
8 stars 10 forks source link

Naive incident store fix #171

Closed JonahSussman closed 1 month ago

JonahSussman commented 2 months ago

NOTE: With the new solved incidents being included, the prompts can get too long and might fail. I added a piece of code to remove the solved incidents when the request fails. A better fix would be to create a new method on the model provider base class to parse why it failed. Feel free to block this merge if you guys want to go that approach.

fabianvf commented 2 months ago

Waiting for merge makes sense :+1:

I didn't see an increase in error rates with mixtral using this branch. Results here: https://github.com/konveyor-ecosystem/coolstore/pull/25/files

JonahSussman commented 1 month ago

Closing for now. Incident store refactor might make this redundant.