konveyor / analyzer-lsp

Add-on that is focused on providing analysis based on the Language Server Protocol.
Apache License 2.0
12 stars 45 forks source link

[BUG] [RULES] False positive on "javax.xml.soap.SOAPElementFactory.create() must be replaced" jakarta-soap-00020 #652

Closed abrugaro closed 3 months ago

abrugaro commented 4 months ago

Is there an existing issue for this?

Konveyor version

0.5 beta 1

Priority

Undefined (Default)

Anything else?

Tested with Kantra b0.5 beta1 Target: eap8 (and others) Source: none Source code used: https://github.com/sonatype/nexus-public Rule triggered: jakarta-soap-00020 javax.xml.soap.SOAPElementFactory.create() must be replaced Report: https://drive.google.com/file/d/1TbdLS4_728DgxbB88F7YcXw84jK2elty/view?usp=drive_link

This rule reported 6 incidents for the application, all of them were related to calls to create methods not related to the javax.xml.soap.SOAPElementFactory class

image Tested with Kantra b0.5 beta1 Target: eap8 (and others) Source: none Source code used: https://github.com/sonatype/nexus-public Rule triggered: jakarta-soap-00020 javax.xml.soap.SOAPElementFactory.create() must be replaced Report: https://drive.google.com/file/d/1TbdLS4_728DgxbB88F7YcXw84jK2elty/view?usp=drive_link

This rule reported 6 incidents for the application, all of them were related to calls to create methods not related to the javax.xml.soap.SOAPElementFactory class

image

image

konveyor-ci-bot[bot] commented 4 months ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members.

dymurray commented 4 months ago

We think some changes going in to improve on method call matching might help to improve this. @jmle is looking into this.

dymurray commented 3 months ago

Confirmed this is no longer an issue in 0.5.0-rc.1