search

konveyor / analyzer-lsp

Add-on that is focused on providing analysis based on the Language Server Protocol.
Apache License 2.0
12 stars 45 forks source link

:bug: unable to run binary path with maven output log #665

Closed shawn-hurley closed 4 months ago

eemcmullan commented 4 months ago

@shawn-hurley Is this something that'd be better to comment out and add a TODO until we understand more of the issue? To unblock using binaryPath for now

shawn-hurley commented 4 months ago

I don't think we need this info it's a on of info and we handle the warnings and log when it errors and we fall back. I think I am ok with just removing it. Good thought though just me 2c if you feel strongly I can do it the other way I am not tied to either approach

eemcmullan commented 4 months ago

That makes sense. No strong feelings - LGTM