search

konveyor / editor-extensions

Developer experience stuff, like VSCode Extension, for Konveyor.
0 stars 8 forks source link

[vscode/webview] need a button on a particular violation to generate fix #67

Open djzager opened 1 month ago

djzager commented 1 month ago

this may already exist.

Definition of Done:

  1. We expose a "generate fix" button in our webview after a user has performed an an analysis and is navigating. violations.
djzager commented 3 weeks ago

I think this one is nearly done. I think we need to update this to be "Get Solution" and connect it to our, not yet implemented, GetSolution function in the analyzerClient.

Could you confirm this @ibolton336 ?

Originally, I had thought we might want to make this button more plainly visible instead of under a kebab dropdown type menu but @sjd78 's wireframes had it there. You (@sjd78) still good with it being in the dropdown?

djzager commented 3 weeks ago

Additionally, I think this issue need to expand in it's scope. Instead of simply rendering or updating the button, I think it should cover the whole flow (from the webviews perspective) from:

  1. The user clicks the "Generate Fix" or "Get Solution"...to
  2. When the user "reconciles" the proposed solution(s).

This includes rendering/disabling user input into the webview while a solution is being retrieved AND preventing the user from proceeding until they have accepted/rejected/modified manually the proposed solution.