search

konveyor / editor-extensions

Developer experience stuff, like VSCode Extension, for Konveyor.
0 stars 8 forks source link

:sparkles: Load analysis results from file #87

Closed rszwajko closed 3 weeks ago

rszwajko commented 3 weeks ago

Use case:

  1. trigger "Load results from files" command from the palette
  2. select analysis results and/or solutions a) file format: JSON b) loading solutions is a stub - to be continued in follow-up c) if multiple files with analysis results(or solutions) are selected only the first one will be used - possible other approaches are failing the import or merging the files
  3. results are loaded into UI - both VS Code views and our webview

Related refactorings:

  1. decouple loading the data from analyzer client - now it operates on the state only
  2. move diagnosticCollection to the state - it has an extension-wide scope
  3. disable triggering "analysisComplete" message from analyzer client - it duplicates "loadStoredAnalysis" message
  4. move anaylzerResultsts helper to newly created data module - after loading results functionality was moved from the analyzer client it was not used in this module
  5. removed clearing rule sets from "konveyor.runAnalysis" command - delay the action until results will be ready. Loading the new results should overwrite old results.
rszwajko commented 3 weeks ago

https://github.com/user-attachments/assets/3e0bf84e-1edd-4153-877d-867edd4e611c