search

konveyor / enhancements

Enhancements tracking repository for Konveyor
Apache License 2.0
3 stars 33 forks source link

:sparkles: Initial draft of generic authentication and authorization #182

Open shawn-hurley opened 2 weeks ago

jmontleon commented 2 weeks ago

Does this replace or make use of the openshift auth functionality we have in the operator today? https://github.com/konveyor/operator/blob/main/roles/tackle/tasks/main.yml#L45

It's not well tested, and maybe not even well known it is there, and to fully work I believe there'd probably need to be changes to the hub.

shawn-hurley commented 2 weeks ago

Going to be honest @jmontleon I had no idea that existed, and I am not convinced that this would even work. @aufi @jortel Can someone let me know if this even is a valid option?

jmontleon commented 2 weeks ago

Going to be honest @jmontleon I had no idea that existed, and I am not convinced that this would even work. @aufi @jortel Can someone let me know if this even is a valid option?

I added this. It worked at the time, but I have not tested it in a long time. It uses the OpenShift oauth-proxy. It only provided authentication, no authorization, so once authenticated you could do anything.

shawn-hurley commented 2 weeks ago

Thank you for reminding me about this! I had forgetten this option. I have a feeling it still works and something that I will need to add:

  1. What to do with this option
  2. What to do IF this option is in use during upgrade