konveyor / enhancements

Enhancements tracking repository for Konveyor
Apache License 2.0
3 stars 35 forks source link

[RFE] Allow users to dismiss issues #185

Open rromannissen opened 2 months ago

rromannissen commented 2 months ago

What is the problem?

Analysis might produce issues that are not meaningful for the user. These issues might come from false positives (which should be reported and considered a problem to solve by the Konveyor team) or from the rules being too orthodox, especially the ones that come out of the box with the tool. It should be possible for the knowledgeable user to dismiss issues that are not applicable in the context of a certain organization or are explicitly not going to be addressed.

A valid example for the need of this could be for an organization that wishes to migrate to EAP 7. Part of those rules include the upgrade of Hibernate to the version that comes packaged with the application server, considering that deployed applications make full use of the available libraries in the Application Server, but the organization packages the Hibernate library with the application itself as a direct dependency. This means that the rules related to the Hibernate upgrade wouldn't apply, as it is not required in this case. While it is true that the user could skip those Hibernate rules by adding their labels to the ignore list for the analysis, that would require a way deeper knowledge of the inner workings of Konveyor and the rules that come bundled with it, which would only be applicable for very advanced users.

Why is this a problem?

Too much noise in the analysis results might render them unusable. It should be up to the experienced user to determine which issues should be addressed in the context of a modernization initiative. If certain issues do not apply in the context of an organization or are not going to be addressed for valid reasons as explained in the previous section, it doesn't make sense to still display story points for applications that are affected by them.

Allowing architects to dismiss certain issues would also allow them to maintain the focal point in what is important for the organization and prioritize work for the migrators.

Proposed solution

Open Questions

konveyor-ci-bot[bot] commented 2 months ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members.

shawn-hurley commented 1 month ago

Enhancement: #197