search

konveyor / go-konveyor-tests

Apache License 2.0
1 stars 14 forks source link

Fixing tests branch in workflows #205

Closed mguetta1 closed 2 weeks ago

mguetta1 commented 3 weeks ago

Use github.ref in TIER tests for release branches. github.ref is the branch triggered the workflow run. For workflows triggered by push, this is the branch or tag ref that was pushed. For workflows triggered by pull_request, this is the pull request merge branch. For more information, see: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context

mguetta1 commented 2 weeks ago

Thanks @aufi! Without this change, the target branch of a PR will be used for testing instead of the source branch (the changes we want to check). Like in here: https://github.com/konveyor/go-konveyor-tests/actions/runs/11701804734/job/32588654384 - Daytrader analysis failed because the tests branch was release-0.5 and not the PR source branch

aufi commented 2 weeks ago

Ah, sorry, thanks for explanation, LGTM.