search

konveyor / go-konveyor-tests

Apache License 2.0
1 stars 14 forks source link

[RFR] Fix Apache wicket app analysis failure #213

Closed nachandr closed 3 days ago

nachandr commented 6 days ago

Apache_wicket

nachandr commented 5 days ago

Thanks @nachandr for the PR. Could you please add analysis tag and dependencies checks?

Analysis tags and dependencies are not generated with the selected target.

mguetta1 commented 5 days ago

Thanks @nachandr for the PR. Could you please add analysis tag and dependencies checks?

Analysis tags and dependencies are not generated with the selected target.

Good, please set the expected result to an empty array so if something changes we can catch it - Dependencies: []api.TechDependency{} Thanks!

Thanks @mguetta1. Just want to make sure I have this right. Are you referring to a placeholder for the future or something else? If it's just a placeholder , I think we could leave the code as is and add the dependencies when they do get generated.

mguetta1 commented 4 days ago

Thanks @nachandr for the PR. Could you please add analysis tag and dependencies checks?

Analysis tags and dependencies are not generated with the selected target.

Good, please set the expected result to an empty array so if something changes we can catch it - Dependencies: []api.TechDependency{} Thanks!

Thanks @mguetta1. Just want to make sure I have this right. Are you referring to a placeholder for the future or something else? If it's just a placeholder , I think we could leave the code as is and add the dependencies when they do get generated.

Hi, not a placeholder but an empty array to make sure that this is the expected behavior instead of skipping the Dependencies check

nachandr commented 4 days ago

Thanks @nachandr for the PR. Could you please add analysis tag and dependencies checks?

Analysis tags and dependencies are not generated with the selected target.

Good, please set the expected result to an empty array so if something changes we can catch it - Dependencies: []api.TechDependency{} Thanks! Thanks @mguetta1. Just want to make sure I have this right. Are you referring to a placeholder for the future or something else? If it's just a placeholder , I think we could leave the code as is and add the dependencies when they do get generated.

Hi, not a placeholder but an empty array to make sure that this is the expected behavior instead of skipping the Dependencies check

Sure, I could do that in a follow up PR . I'd also like to check if analysis_test.go needs to be updated.

nachandr commented 4 days ago

Thanks @nachandr for the PR. Could you please add analysis tag and dependencies checks?

Analysis tags and dependencies are not generated with the selected target.

Good, please set the expected result to an empty array so if something changes we can catch it - Dependencies: []api.TechDependency{} Thanks! Thanks @mguetta1. Just want to make sure I have this right. Are you referring to a placeholder for the future or something else? If it's just a placeholder , I think we could leave the code as is and add the dependencies when they do get generated.

Hi, not a placeholder but an empty array to make sure that this is the expected behavior instead of skipping the Dependencies check

Sure, I could do that in a follow up PR . I'd also like to check if analysis_test.go needs to be updated.

https://github.com/konveyor/go-konveyor-tests/pull/221/

nachandr commented 4 days ago

Hi @aufi and @pranavgaikwad , Dependencies and Tags were not found during the analysis of the Apache Wicket app with target=cloud-readiness . At some point, a few Analysis tags would get generated, but they don't generated anymore (as seen in this PR).

Is this expected?

nachandr commented 3 days ago

Hi @nachandr, this test case specifies path within the source repository, so looking on the sample app: https://github.com/windup/windup-sample-apps/tree/master/test-files/src_example/org/apache/wicket, no dependencies is (probably) correct, there is no pom.xml in the directory subtree.

Generally, there should be tags at least from language discovery (Java and Maven for this app), but these come from language-discovery task triggered automatically with application creation. So, they might have appeared in case analysis has finished later than the language discovery. This is not common on most applications, but here, the application looks to be just a bunch of .java files, so analysis might be pretty fast. This could explain sometimes generated tags.

I tested the analysis locally, except the discovery tags, results are the same and since this is analysis tests more that discovery tests, this PR with empty Dependencies and Tags is LGTM.

@aufi , Thank you !