konveyor / kai

Konveyor AI - static code analysis driven migration to new targets via Generative AI
Apache License 2.0
25 stars 32 forks source link

Coolstore Example: No attempt to migrate the file model/CatalogItemEntity.java which has 'import javax.persistence.*;' #138

Open jwmatthews opened 7 months ago

jwmatthews commented 7 months ago

I saw that a file I expected we would have tried to migrate was never attempted.

https://github.com/konveyor-ecosystem/coolstore/blob/main/src/main/java/com/redhat/coolstore/model/CatalogItemEntity.java#L3C7-L3C28

It has an import of 'javax' which I assume we need to change. import javax.persistence.*; My first thought was we tried and failed so skipped it, but I didn't see any attempts to migrate this in the run_demo.py output. I looked through the Kantra analysis and I don't see any entries of a violation found for this file.

Here is a link to the analysis output we are using: https://github.com/konveyor-ecosystem/kai/blob/main/example/analysis/coolstore/output.yaml

This is how we ran the analysis to recreate: https://github.com/konveyor-ecosystem/kai/blob/main/example/analyze.sh

Also confirmed via:

$ ./list_violations_for_file.py src/main/java/com/redhat/coolstore/model/CatalogItemEntity.java  
INFO - 2024-04-02 13:49:55,847 - [report.py:79 -         _read_report() ] - Reading report from ./analysis/coolstore/output.yaml
File 'src/main/java/com/redhat/coolstore/model/CatalogItemEntity.java' does not have any violations
jwmatthews commented 7 months ago

I reran the analysis with latest Kantra as of 4/2/2024 and verified same results, no mention of CatalogItemEntity.java