search

konveyor / kantra

A CLI that unifies analysis and transformation capabilities of Konveyor
Apache License 2.0
9 stars 27 forks source link

:fix :(docs): changed env PODMAN_BIN to CONTAINER_TOOL #305

Closed soham4abc closed 3 months ago

soham4abc commented 3 months ago

This PR changes the environment variable PODMAN_BIN to CONTAINER_TOOL

as kantra falls back to docker if podman is not present, this variable name makes much more sense.

@dagood Please do have a look and provide any necessary feedback for the same.

Closes #168

eemcmullan commented 3 months ago

@soham4abc apologies for the confusion. After discussing with @shawn-hurley we think it's best to support PODMAN_BIN for a while longer. Can we first check for this var? If CONTAINER_TOOL is also set, we will want to use that instead.

soham4abc commented 3 months ago

@soham4abc apologies for the confusion. After discussing with @shawn-hurley we think it's best to support PODMAN_BIN for a while longer. Can we first check for this var? If CONTAINER_TOOL is also set, we will want to use that instead.

Sure... Do you want me to revert the changes to ```PODMAN_BIN?

eemcmullan commented 3 months ago

@soham4abc We still want to move forward with CONTAINER_TOOL. But for the sake of compatibility, we should probably check for PODMAN_BIN and CONTAINER_TOOL together. If both are set, use CONTAINER_TOOL. If only one or the other, use that.

soham4abc commented 3 months ago

@soham4abc We still want to move forward with CONTAINER_TOOL. But for the sake of compatibility, we should probably check for PODMAN_BIN and CONTAINER_TOOL together. If both are set, use CONTAINER_TOOL. If only one or the other, use that.

hey @eemcmullan I have made the changes can you please have a look and test on your end!

soham4abc commented 3 months ago

@eemcmullan can you please have a look and run the CI tests?

soham4abc commented 3 months ago

@shawn-hurley can you please have a look at the changes and provide your reviews?