konveyor / kantra

A CLI that unifies analysis and transformation capabilities of Konveyor
Apache License 2.0
9 stars 27 forks source link

[BUG] The presence of a `source` should not be required for a rule to be triggered #342

Open jmle opened 1 month ago

jmle commented 1 month ago

Is there an existing issue for this?

Konveyor version

0.5.3

Priority

Critical

Current Behavior

Currently, for a rule to be picked up by kantra, is not enough for it to have a target label:

  labels:
  - konveyor.io/target=quarkus

it needs to have at least one source label too:

  labels:
  - konveyor.io/source=java-ee
  - konveyor.io/source=jakarta-ee
  - konveyor.io/target=quarkus

This doesn't make sense, as sources should not be mandatory.

Expected Behavior

A rule with only targets:

  labels:
  - konveyor.io/target=quarkus

should be picked up without the need of having sources.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Create a rule without source labels, but with a target label for quarkus
  2. Run against an application with --target quarkus
  3. See how the rule is not even picked up

Environment

Any environment

Anything else?

No response

konveyor-ci-bot[bot] commented 1 month ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members.