search

konveyor / kantra

A CLI that unifies analysis and transformation capabilities of Konveyor
Apache License 2.0
9 stars 27 forks source link

:seedling: Extract getConfigVolumes to an interface #372

Open abrugaro opened 1 week ago

abrugaro commented 1 week ago

This PR addresses issue #249. I have modified the getConfigVolume method to extract the configuration creation for each provider into an interface implemented by each corresponding struct

Initially, my idea was to place the provider structs in an internal package. However, the analyzeCommand does not export any parameters, and I didn't want to change that in this PR since I don't have enough context on the code.

I also considered refactoring other elements, such as separating the analyzeCommand itself from the execution context (which is currently also added to analyzeCommand). However, I decided not to address this in this PR because I wasn't entirely sure about the scope of the issue

@eemcmullan Should I address what I mention in this PR as well? Is there anything else I'm missing regarding the issue?

Thanks!

CC @jmle