konveyor / mig-demo-apps

A collection of apps ideal for migration demos
Apache License 2.0
15 stars 70 forks source link

robot-shop: Fix deployment API version for OCP 3.7 #9

Closed fbladilo closed 5 years ago

fbladilo commented 5 years ago

The v1 deployment API on manifests is too new for OCP 3.7, this release was on v1beta1 for Deployments : https://docs.openshift.com/container-platform/3.7/rest_api/apis-apps/v1beta1.Deployment.html

This is the error out of k8s ansible module :

TASK [robot-shop : Deploy robot-shop sample] **********************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Failed to find exact match for apps.openshift.io/v1.Deployment by [kind, name, singularName, shortNames]"}

PLAY RECAP ********************************************************************************************************************************************************************************************************
localhost                  : ok=9    changed=2    unreachable=0    failed=1    skipped=17   rescued=0    ignored=0   
pranavgaikwad commented 5 years ago

@fbladilo Looking good. Tested on 3.11. If it works for you on 3.7, good to merge...

fbladilo commented 5 years ago

@pranavgaikwad Yep tested on OCP 3.7 ...