search

konveyor / move2kube-api

HTTP REST API for move2kube
https://move2kube.konveyor.io/
Apache License 2.0
6 stars 18 forks source link

Remove golint errors and add config file for golint #22

Closed burnerlee closed 4 years ago

burnerlee commented 4 years ago

I have removed most of the golint errors. You will need to add comments to all the exported function in the following format: // Add adds two given numbers and returns their value func Add(a,b int){ return a+b } Since i have less idea of your project and usage of functions, i'll the adding comments to you. I have fixed the other linting issue. Also i have added a golang config file (.golangci.yml) which would check for golint errors using the command golangci-lint run in the terminal itself. I have only added golint checks in the file configs. I have also added a sample file name (.golangci_sample.yml) with other checks like gosec and errcheck which i use personally for my go projects. Please have a look over them. Otherwise inserting the comments for each exported functions and variables would give you full score in the report card itself.

burnerlee commented 4 years ago

It builds and run on my system. Could you please tell why is it failing in checks here?

ashokponkumar commented 4 years ago

Thanks for the changes @burnerlee . This looks good. Travis is failing because it does make test-style too. I will accept the changes now, and will fix the build in the next commit.

Please do feel free to continue to contribute to the project.