konveyor / move2kube-api

HTTP REST API for move2kube
https://move2kube.konveyor.io/
Apache License 2.0
6 stars 18 forks source link

feat: Use docker or podman to build and run #88

Closed rmarting closed 3 years ago

rmarting commented 3 years ago

This PR improves the Makefile to check which container tool is installed in the enviroment (only docker or podman).

The user will not have to set up anything before to build or to run the image locally, only a container tool is needed to be installed.

HTH

github-actions[bot] commented 3 years ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

rmarting commented 3 years ago

@ashokponkumar Here the PR as you request me related with https://github.com/konveyor/move2kube-ui/pull/98

Ready for your review.

rmarting commented 3 years ago

@HarikrishnanBalagopal I don't know why DCO is not passing. I followed the instructions to signoff my latest commit, but it is something not working.

From my local repo:

move2kube-api on  use-container-tool via 🐹 v1.16.8 via ⬢ v10.17.0 took 8s 
❯ git commit --amend --no-edit --signoff
[use-container-tool bfa4189] :twisted_rightwards_arrows: Merge branch 'use-container-tool' of https://github.com/rmarting/move2kube-api into use-container-tool
 Date: Thu Sep 30 12:06:19 2021 +0200
move2kube-api on  use-container-tool via 🐹 v1.16.8 via ⬢ v10.17.0 
❯ git push --force-with-lease origin use-container-tool
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 311 bytes | 311.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/rmarting/move2kube-api.git
 + c4d900a...bfa4189 use-container-tool -> use-container-tool (forced update)

What am I doing wrong?

ashokponkumar commented 3 years ago

@HarikrishnanBalagopal I don't know why DCO is not passing. I followed the instructions to signoff my latest commit, but it is something not working.

From my local repo:

move2kube-api on  use-container-tool via 🐹 v1.16.8 via ⬢ v10.17.0 took 8s 
❯ git commit --amend --no-edit --signoff
[use-container-tool bfa4189] :twisted_rightwards_arrows: Merge branch 'use-container-tool' of https://github.com/rmarting/move2kube-api into use-container-tool
 Date: Thu Sep 30 12:06:19 2021 +0200
move2kube-api on  use-container-tool via 🐹 v1.16.8 via ⬢ v10.17.0 
❯ git push --force-with-lease origin use-container-tool
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 311 bytes | 311.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/rmarting/move2kube-api.git
 + c4d900a...bfa4189 use-container-tool -> use-container-tool (forced update)

What am I doing wrong?

Possibly one of the commits ( I guess the merge commit) does not have the sign off. Possibly you can squash and sign that commit.

rmarting commented 3 years ago

Possibly one of the commits ( I guess the merge commit) does not have the sign off. Possibly you can squash and sign that commit.

Squash some commits into single one, but now this PR includes my changes and others coming from the main branch. TBH I don't know what it is happeing, but at least the commits include my changes.

Ready for your review.

ashokponkumar commented 3 years ago

Possibly one of the commits ( I guess the merge commit) does not have the sign off. Possibly you can squash and sign that commit.

Squash some commits into single one, but now this PR includes my changes and others coming from the main branch. TBH I don't know what it is happeing, but at least the commits include my changes.

Ready for your review.

Can you please try a rebase with main? It shows a warning that the branch is out of date.

rmarting commented 3 years ago

Done!