search

konveyor / move2kube-ui

An UI for interacting with Move2Kube API
https://move2kube.konveyor.io/
Apache License 2.0
10 stars 14 forks source link

Optimize Dockerfile #7

Closed ashokponkumar closed 3 years ago

ashokponkumar commented 3 years ago
  1. Optimize the Dockerfile to use a server
  2. Build artifacts and host in server
jams008 commented 3 years ago

hi, can i help with dockerfile optimization, as best i can?

ashokponkumar commented 3 years ago

sure @jams008

jams008 commented 3 years ago

thank you, okay will me

jmontleon commented 3 years ago

You may want to look at https://github.com/konveyor/mig-ui/blob/master/Dockerfile as one example of how to build assets on a build container (which is discarded afterwards) and copy them to a runtime container using a multi-stage build.

ashokponkumar commented 3 years ago

Thanks @jmontleon . @jams008 Do you want to have a look at https://github.com/konveyor/mig-ui/blob/master/Dockerfile and try it out for move2kube-ui?

jams008 commented 3 years ago

I optimized the base image which was smaller before, up to 1GB, now it is only 300 MB, I tidy up the writing structure and I update the docker-compose file to build automatically when it's up. #14

jams008 commented 3 years ago

Hi @ashokponkumar , I fixed it and used 'git commit -a -m' but the ci DCO still got an error.

ashokponkumar commented 3 years ago

@jams008 It is git commit -s -m message

jams008 commented 3 years ago

yes I've used it ![Uploading image.png…]()

ashokponkumar commented 3 years ago

Closed by #14