konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
383 stars 118 forks source link

feat: add an option to let the user provide the ssh keys #1041

Closed HarikrishnanBalagopal closed 11 months ago

HarikrishnanBalagopal commented 1 year ago

Feature request

https://github.com/konveyor/move2kube/blob/87d53a2b63fc7670cece3a0ae871c0f87e120c3f/common/sshkeys/sshkeys.go#L105-L107

Change to a Select type question and add an option to let the user provide the entire key PEM data as the answer.

Context

This is useful when using the UI and generating a Tekton pipeline. The pipeline needs creds in order to clone the repo. The UI/API server running in a different machine won't have access to the users' ~/.ssh folder to get the keys.

eloycoto commented 1 year ago

Also, the one for kaniko: https://tekton.dev/docs/how-to-guides/kaniko-build-push/#container-registry-authentication

HarikrishnanBalagopal commented 1 year ago

Also, the one for kaniko: https://tekton.dev/docs/how-to-guides/kaniko-build-push/#container-registry-authentication

https://github.com/konveyor/move2kube/blob/87d53a2b63fc7670cece3a0ae871c0f87e120c3f/transformer/kubernetes/tektontransformer.go#L253-L262

https://github.com/konveyor/move2kube/blob/87d53a2b63fc7670cece3a0ae871c0f87e120c3f/transformer/kubernetes/tektontransformer.go#L47

eloycoto commented 1 year ago

Ok, regarding this:

I've just tried something like this:

    imageregistry:
      quay.io:
        logintype: use an existing pull secret
        pullsecret: parodosSecret
      namespace: parodos
      url: quay.io

And the secret is used on openshift-template/helm-chart/kustomize and yamls, but it's not part of the tekton pipeline workspaces at all.