search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
383 stars 118 forks source link

bug: DefaultExecutablePermission is not used anywhere #1103

Closed HarikrishnanBalagopal closed 5 months ago

HarikrishnanBalagopal commented 10 months ago

https://github.com/konveyor/move2kube/blob/73077ae4f7e79f9c7f95208963ba284407f627af/common/constants.go#L42

image

Related

How are executable scripts like buildimages.sh produced with the correct permissions?

Seems to be coming from https://github.com/konveyor/move2kube/blob/73077ae4f7e79f9c7f95208963ba284407f627af/assets/filepermissions.yaml#L34

https://github.com/konveyor/move2kube/blob/73077ae4f7e79f9c7f95208963ba284407f627af/main.go#L31-L32

Akash-Nayak commented 10 months ago

How are executable scripts like buildimages.sh produced with the correct permissions?

@HarikrishnanBalagopal, I think the original permissions of the files (like, buildimages.sh, pushimages.sh, etc.) in the local machine, which is used for pushing these files, gets added/updated in the filepermissions.yaml file when we run make generate.

Soumil-07 commented 10 months ago

I checked the blame output for constants.go, and DefaultExecutablePermission was added in the very 2nd commit 3 years ago: 6b90cbd5453c8eddf894823a62ef8373c043c8c7. Even back then, it wasn't used anywhere.