search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
383 stars 118 forks source link

bug: version metadata is empty when the tag is non empty? #1112

Closed HarikrishnanBalagopal closed 7 months ago

HarikrishnanBalagopal commented 10 months ago

https://github.com/konveyor/move2kube/blame/e88ceceee7e8e76a587827d9555035566d4d0b38/Makefile#L58

akagami-harsh commented 9 months ago

@HarikrishnanBalagopal , can you please give some more information about the issue

HarikrishnanBalagopal commented 9 months ago

@HarikrishnanBalagopal , can you please give some more information about the issue

cc: @ashokponkumar The VERSION_METADATA was added a long time ago

https://github.com/konveyor/move2kube/blame/e88ceceee7e8e76a587827d9555035566d4d0b38/Makefile#L56-L59

VERSION_METADATA = unreleased
ifneq ($(GIT_TAG),)
    VERSION_METADATA =
endif

not sure if this is really a bug? Few options instead of leaving it empty: