konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
383 stars 118 forks source link

test:add tests for fileinfo.go #1138

Open satyazzz123 opened 8 months ago

satyazzz123 commented 8 months ago

added tests for fileinfo.go functions

fixes a part of: #884

github-actions[bot] commented 8 months ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3fd2033) 14.85% compared to head (b682725) 14.95%.

:exclamation: Current head b682725 differs from pull request most recent head c5fc7ca. Consider uploading reports for the commit c5fc7ca to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1138 +/- ## ========================================== + Coverage 14.85% 14.95% +0.09% ========================================== Files 90 90 Lines 8379 8379 ========================================== + Hits 1245 1253 +8 + Misses 6813 6805 -8 Partials 321 321 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

satyazzz123 commented 8 months ago

@kmehant @seshapad @HarikrishnanBalagopal I have raised a PR for testing fileinfo.go. Please have a look

kmehant commented 8 months ago

@satyazzz123 thank you for the PR. Shall we close this PR (https://github.com/konveyor/move2kube/pull/1124) first before we move on to new ones? Please update the PR when you are able to and let us know. Appreciate your contributions.

satyazzz123 commented 8 months ago

@satyazzz123 thank you for the PR. Shall we close this PR (#1124) first before we move on to new ones? Please update the PR when you are able to and let us know. Appreciate your contributions.

Almost done with the changes will push those changes for #1124 . Sorry for the delay.