search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
377 stars 119 forks source link

docs: add instructions for setting an alias for the `move2kube` command in the shell #1139

Closed Sanket-0510 closed 3 months ago

Sanket-0510 commented 5 months ago

as discussed here #1135 I feel there is a strong need to address, its all okay if we can't change it during installation but shall surely have section to address the same. Because writing 'move2kube' becomes a tedious task for sure.

github-actions[bot] commented 5 months ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

KrishAryan commented 5 months ago

@Sanket-0510 I think you forgot to sign your commit.

To fix this please read this

Also please read the contribution.md

Sanket-0510 commented 5 months ago

@Sanket-0510 I think you forgot to sign your commit.

To fix this please read this

Also please read the contribution.md

Hey @KrishAryan you can review this.

KrishAryan commented 5 months ago

@Sanket-0510 I think it would look better if you write 'To keep aliases between sessions, you can save them in your user’s shell configuration profile file' and give the example of only bash script otherwise the readme will look unnecessarily long. I am not a maintainer so I cannot approve this for you but wanted to help save their time.

Sanket-0510 commented 5 months ago

@Sanket-0510 I think it would look better if you write 'To keep aliases between sessions, you can save them in your user’s shell configuration profile file' and give the example of only bash script otherwise the readme will look unnecessarily long. I am not a maintainer so I cannot approve this for you but wanted to help save their time.

will you please highlight in the code, the exact place

Sanket-0510 commented 5 months ago

between line 127 and line 129 you can add the comment and remove zsh and fish section.Also use three hashags in line 127 instead of two so that it can look better.

Also in your second commit which is in go.mod file, why did you do the changes in line 22 and removed line 119

Hey, actually, it's the Go package manager, I guess, which made the changes. I didn't explicitly change it, and the build is successful on my side, I ran these commands, go fmt go mod tidy make ci may be thats go removing the unnecessary dependencies

KrishAryan commented 5 months ago

@kmehant can you please review and approve it?