search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
383 stars 118 forks source link

fix: QA categories were being used only by the CLI engine #1156

Closed Akash-Nayak closed 6 months ago

Akash-Nayak commented 6 months ago

Updated the QA http rest engine of Move2Kube required for adding QA category enable/disable support to Move2Kube API https://github.com/konveyor/move2kube/issues/1155, https://github.com/konveyor/move2kube/issues/1151#issuecomment-1993816895. For the disabled categories, the QA engine should automatically consider the default answer as the input answer.

Signed-off-by: Akash Nayak akash19nayak@gmail.com

github-actions[bot] commented 6 months ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 14.89%. Comparing base (c8164a0) to head (c0ef8d7).

Files Patch % Lines
qaengine/engine.go 33.33% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1156 +/- ## ========================================== + Coverage 14.86% 14.89% +0.02% ========================================== Files 90 90 Lines 8376 8380 +4 ========================================== + Hits 1245 1248 +3 + Misses 6810 6809 -1 - Partials 321 323 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarikrishnanBalagopal commented 6 months ago

Related https://github.com/konveyor/move2kube/issues/1154