search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
377 stars 119 forks source link

feat: podman multiarch support #1157

Closed shashank381 closed 2 months ago

github-actions[bot] commented 3 months ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 14.82%. Comparing base (3bf7465) to head (3c96f4f).

:exclamation: Current head 3c96f4f differs from pull request most recent head 99e8b8b. Consider uploading reports for the commit 99e8b8b to get more accurate results

Files Patch % Lines
common/utils.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1157 +/- ## ========================================== + Coverage 14.79% 14.82% +0.02% ========================================== Files 90 90 Lines 8401 8385 -16 ========================================== Hits 1243 1243 + Misses 6835 6819 -16 Partials 323 323 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Akash-Nayak commented 3 months ago

Also, @shashank381 can you please add Soumil as the co-author in this PR, as part of this PR has been taken from the original PR https://github.com/konveyor/move2kube/pull/1101.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line

shashank381 commented 3 months ago

Thank you @Akash-Nayak I have updated the bat file.

Can you please also test the following scenarios and see if things are working as expected or not -

  1. ./buildandpush_multiarchimages.bat podman index.docker.io <your_quay_username> linux/amd64,linux/arm64,linux/s390x
  2. ./buildandpush_multiarchimages.bat docker index.docker.io <your_quay_username>
  3. ./buildandpush_multiarchimages.bat podman
  4. ./buildandpush_multiarchimages.bat

I dont have a windows machine to test these cases.

shashank381 commented 2 months ago

@Akash-Nayak I have manually validated logic for bat scripts. Thankyou.