Closed Akash-Nayak closed 3 months ago
Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 14.89%. Comparing base (
03e702f
) to head (b4fe65b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Akash-Nayak the bug was caused by this PR https://github.com/konveyor/move2kube-api/pull/148/files
The bug was fixed in https://github.com/konveyor/move2kube-api/pull/163
We can merge this PR regardless but some minor change is required.
@Akash-Nayak the bug was caused by this PR https://github.com/konveyor/move2kube-api/pull/148/files
When there is no .m2kignore
file and if there is Ruby service in the source artifacts, then Move2Kube CLI/UI would only detect the Ruby service and ignore all other services.
ls -a src
. golang java-maven python rust
.. java-gradle nodejs ruby
$ move2kube plan -s src
$ cat m2k.plan
apiVersion: move2kube.konveyor.io/v1alpha1
kind: Plan
metadata:
name: myproject
spec:
sourceDir: src
services:
src:
- transformerName: Ruby-Dockerfile
paths:
ServiceDirectories:
- .
configs:
OriginalName:
originalName: src
transformers:
This PR fixes this issue https://github.com/konveyor/move2kube/pull/1160#issue-2198468714.
Fixes - https://github.com/konveyor/move2kube/issues/1159
Move2Kube-UI detects all the services in the language-platforms, whereas earlier it was only detecting the Ruby service.