search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
377 stars 119 forks source link

fix: bug where all yaml files were treated as K8s yamls by the Parameterizer #1162

Closed HarikrishnanBalagopal closed 3 months ago

HarikrishnanBalagopal commented 3 months ago

Avoid these errors

ERRO[0001] Unable to parameterize for helm : there is no kind specified in the k8s resource map[resources:[enterprise-app-run-clone-build-push-triggertemplate.yaml frontend-vcapasenv-secret.yaml enterprise-app-clone-build-push-pipeline.yaml enterprise-app-git-event-triggerbinding.yaml enterprise-app-git-repo-eventlistener.yaml enterprise-app-image-registry-secret.yaml enterprise-app-ingress.yaml enterprise-app-tekton-triggers-admin-role.yaml enterprise-app-tekton-triggers-admin-rolebinding.yaml enterprise-app-tekton-triggers-admin-serviceaccount.yaml enterprise-app-clone-push-serviceaccount.yaml orders-vcapasenv-secret.yaml gateway-vcapasenv-secret.yaml]] 
ERRO[0001] Unable to parameterize /var/folders/81/pzmd85sj2d9dg02xgmd7wlhr0000gn/T/move2kube1886420936/environment-Parameterizer-2689628992/3778034170/base-parameterized/kustomize/base/kustomization.yaml : there is no kind specified in the k8s resource map[resources:[enterprise-app-run-clone-build-push-triggertemplate.yaml frontend-vcapasenv-secret.yaml enterprise-app-clone-build-push-pipeline.yaml enterprise-app-git-event-triggerbinding.yaml enterprise-app-git-repo-eventlistener.yaml enterprise-app-image-registry-secret.yaml enterprise-app-ingress.yaml enterprise-app-tekton-triggers-admin-role.yaml enterprise-app-tekton-triggers-admin-rolebinding.yaml enterprise-app-tekton-triggers-admin-serviceaccount.yaml enterprise-app-clone-push-serviceaccount.yaml orders-vcapasenv-secret.yaml gateway-vcapasenv-secret.yaml]]
github-actions[bot] commented 3 months ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 14.84%. Comparing base (14357a9) to head (0d8d154).

Files Patch % Lines
...nsformer/kubernetes/parameterizer/parameterizer.go 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1162 +/- ## ========================================== - Coverage 14.91% 14.84% -0.08% ========================================== Files 90 90 Lines 8380 8367 -13 ========================================== - Hits 1250 1242 -8 + Misses 6805 6802 -3 + Partials 325 323 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.