search

konveyor / move2kube

Move2Kube is a command-line tool for automating creation of Infrastructure as code (IaC) artifacts. It has inbuilt support for creating IaC artifacts for replatforming to Kubernetes/Openshift.
https://move2kube.konveyor.io/
Apache License 2.0
383 stars 118 forks source link

bug: in the ArgoCD application yaml actually set the namespace based on user input #930

Closed HarikrishnanBalagopal closed 1 year ago

HarikrishnanBalagopal commented 1 year ago

Bug

Overview

Currently the field is not being set by anything. https://github.com/konveyor/move2kube/blob/8aa892e2b4b50eaa67073358dbc85f6988dd7f3c/transformer/kubernetes/apiresource/argocdapplication.go#L84

https://github.com/konveyor/move2kube/blob/8aa892e2b4b50eaa67073358dbc85f6988dd7f3c/types/ir/argocd.go#L31

The field irApplication.DestNamespace is only referenced in 2 places and it's not being set by either of them. image

Fix

Probably we can use ask the user to provide the namespace where the app should be deployed once the CI/CD pipeline finishes.

MdSahil-oss commented 1 year ago

@HarikrishnanBalagopal, I would like to work on it, Can you assign this issue to me.

HarikrishnanBalagopal commented 1 year ago

@HarikrishnanBalagopal, I would like to work on it, Can you assign this issue to me.

Thanks for your interest, I have assigned it.

HarikrishnanBalagopal commented 1 year ago

@MdSahil-oss Unassigning as this issue is related to LFX. Will need to wait until LFX candidate selection is done to assign someone to it.