konveyor / operator

Konveyor Operator fully manages the deployment and life cycle of Konveyor (formerly Tackle) on Kubernetes and OpenShift.
Apache License 2.0
28 stars 38 forks source link

Support multiple providers. #313

Closed jortel closed 3 months ago

jortel commented 4 months ago

In support multiple providers, the CRDs found here have changed. See pull/606 for latest files.

The installed CRs have also changed found here. See: pull/79 for latest files.

The separation of analyzer and providers mean the addon-analyzer no longer needs as much cpu and memory.

The current variables (and defaults) really apply to the java provider (extension). Let's discuss how to deal with this.

analyzer_container_limits_cpu: "1"
analyzer_container_limits_memory: "4Gi"
analyzer_container_requests_cpu: "1"
analyzer_container_requests_memory: "4Gi"

probably needs new variables?

provider_java_container_limits_cpu: "1"
provider_java_container_limits_memory: "4Gi"
provider_java_container_requests_cpu: "1"
provider_java_container_requests_memory: "4Gi"
konveyor-ci-bot[bot] commented 4 months ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members.

jmontleon commented 4 months ago

@jortel do I understand correctly that we should be replacing: https://github.com/konveyor/operator/blob/main/roles/tackle/templates/customresource-addon-analyzer.yml.j2

with a templatized version of: https://github.com/konveyor/tackle2-addon-analyzer/pull/79/files#diff-cee5d263c7c9eac225a178f916e817e348740f30c11dcfbc28fb3e432684f3b3

or am I off target.

jortel commented 4 months ago

@jortel do I understand correctly that we should be replacing: https://github.com/konveyor/operator/blob/main/roles/tackle/templates/customresource-addon-analyzer.yml.j2

with a templatized version of: https://github.com/konveyor/tackle2-addon-analyzer/pull/79/files#diff-cee5d263c7c9eac225a178f916e817e348740f30c11dcfbc28fb3e432684f3b3

or am I off target.

Correct.