search

konveyor / operator

Konveyor Operator fully manages the deployment and life cycle of Konveyor (formerly Tackle) on Kubernetes and OpenShift.
Apache License 2.0
26 stars 37 forks source link

:sparkles: Support Multiple Providers #314

Closed jmontleon closed 1 month ago

jmontleon commented 1 month ago

I know we discussed replacing the the resources/limits, but looking at this, I wonder if it makes sense to be able to control each individual with its own set of values? If they don't all need to be 1Gi / 1 CPU we can adjust them appropriately. If not I can change it.

jmontleon commented 1 month ago

I don't know if @rayfordj and/or @fbladilo have been made aware that there are a couple of additional images yet, but if not they'd probably appreciate a heads up as well.

jmontleon commented 1 month ago

@jortel looks like there are some test failures. I noticed you were specifying an image in your personal quay org; will we need the updated image for these tests to pass?

jortel commented 1 month ago

@jortel looks like there are some test failures. I noticed you were specifying an image in your personal quay org; will we need the updated image for these tests to pass?

We'll need hub to be merged, then addon-analyzer to go-mod updated, merged, then the test should pass.

jmontleon commented 1 month ago

Once I have feedback on the component names and resources I will update those.

jmontleon commented 1 month ago

@djzager is make bundle being run on the main branch? The CSV being printed out in the logs does not reflect the updates in the PR and the operator is failing to reconcile because it is not creating the Addon with a field that was previously required.