search

konveyor / operator

Konveyor Operator fully manages the deployment and life cycle of Konveyor (formerly Tackle) on Kubernetes and OpenShift.
Apache License 2.0
26 stars 37 forks source link

:sparkles: Update CRDs to v1alpha2 #336

Closed jmontleon closed 3 weeks ago

jmontleon commented 3 weeks ago

@shawn-hurley can you help verify this is correct for adding a new CRD version?

I'm a little iffy. According to https://docs.openshift.com/container-platform/4.15/operators/operator_sdk/osdk-generating-csvs.html

We should Add a new entry in the CRD resource under the versions section of your CSV. There is no versions section of a CSV that I am aware of. There is spec.versions[] in the CRD with served and storage that I believe they're talking about.

And then Ensure the referencing version of the CRD in the owned section of your CSV is updated if the CSV intends to use the new version:.

I guess we just list the new version?

jmontleon commented 3 weeks ago

The tests are failling from:

 TASK [Remove Admin Addon CR] ******************************** 
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Failed to find exact match for tackle.konveyor.io/v1alpha1.Addon by [kind, name, singularName, shortNames]"}

This is fixed by: https://github.com/konveyor/operator/pull/336/files#diff-0a8079fab6ffd92e79e1f91e6bd25cfe01ddc6744210bce9799e5267589d5f54R457

But tests will not pass until everything is merged because the bundle is still using image: quay.io/konveyor/tackle2-operator:latest.

@djzager fyi we have an issue where operator role changes don't get tested. We probably need to build the container image replace it when building the bundle for tests to properly account for changes.