search

konveyor / rulesets

Collections of static code analysis rules
Apache License 2.0
1 stars 17 forks source link

:sparkles: Update rulesets #71

Closed pranavgaikwad closed 4 months ago

pranavgaikwad commented 5 months ago

This is getting all the changes @jmle worked on

API Tests PR: 116

Fixes #48

pranavgaikwad commented 5 months ago

This is getting us 82.57% pass rate:

  Test Cases Summary: 2070/2507 (82.57%) PASSED
aufi commented 5 months ago

Finally got some information about the failure, from the downloaded hub artifact hub, there is something like:

...
time=2024-04-15T14:25:08Z level=info msg=[seeding] Applying seeds.
time=2024-04-15T14:25:08Z level=error msg=[hub] open /tmp/seed/rulesets/jakarta-ee9/ruleset.yaml: no such file or directory
github.com/konveyor/tackle2-seed/pkg.(*RuleSet).readRuleSet()
    /opt/app-root/pkg/mod/github.com/konveyor/tackle2-seed@v0.0.0-20231025181853-8ce94f70f744/pkg/ruleset.go:90
github.com/konveyor/tackle2-seed/pkg.(*RuleSet).Load()
    /opt/app-root/pkg/mod/github.com/konveyor/tackle2-seed@v0.0.0-20231025181853-8ce94f70f744/pkg/ruleset.go:67
github.com/konveyor/tackle2-seed/pkg.(*Seed).DecodeItems()
    /opt/app-root/pkg/mod/github.com/konveyor/tackle2-seed@v0.0.0-20231025181853-8ce94f70f744/pkg/seed.go:78
github.com/konveyor/tackle2-hub/seed.(*RuleSet).With()
    /opt/app-root/src/seed/ruleset.go:24
github.com/konveyor/tackle2-hub/seed.(*Hub).With()
    /opt/app-root/src/seed/seed.go:32
github.com/konveyor/tackle2-hub/seed.Seed()
    /opt/app-root/src/seed/pkg.go:68
main.Setup()
    /opt/app-root/src/cmd/main.go:45
main.main()
    /opt/app-root/src/cmd/main.go:99
runtime.main()
    /usr/lib/golang/src/runtime/proc.go:250
runtime.goexit()
    /usr/lib/golang/src/runtime/asm_amd64.s:1598
panic: open /tmp/seed/rulesets/jakarta-ee9/ruleset.yaml: no such file or directory

goroutine 1 [running]:
main.main()
    /opt/app-root/src/cmd/main.go:101 +0xadb

(executed manually with podman run quay.io/konveyor/tackle2-hub:latest from this build, that might miss some volumes etc, but "official" release-0.3 fails much later)