konveyor / tackle2-addon-analyzer

Apache License 2.0
0 stars 11 forks source link

:bug: Fix Targets (Rulesets) with repositories. #118

Closed jortel closed 1 month ago

jortel commented 1 month ago

https://issues.redhat.com/browse/MTA-3330

A custom target that references a repository will be created with a related RuleSet. A repository may be defined on the ruleSet. An analysis task defines included labels which determine which rulesets are pulled (downloaded) from the hub. Since ruleSets that reference repositories do not have labels, the addon did not know to download it and clone the repository.

Solution: The new rules.ruleSets will be used to pass a list of RuleSet (refs) selected by the user (by selecting targets). Each will be be unconditionally fetched by the addon.

For each ruleset with a repository the addon will:

related: https://github.com/konveyor/tackle2-ui/pull/2034

shawn-hurley commented 1 month ago

I think the label on the rule set itself should fix the issue as it will be added to all rules in the rule set. Probably an optimization to come back too