search

konveyor / tackle2-hub

Tackle (2nd generation) hub component.
Apache License 2.0
6 stars 29 forks source link

Alias api json field types. #532

Open jortel opened 8 months ago

jortel commented 8 months ago

The types defined in the model package for JSON fields should be aliased by the api package instead of being redefined (cut-n-paste). This will ensure they are consistent and that JSON fields can be migrated.

Note: This will likely cause openAPI generation issues/complexity. May not be worth it :-/

RipulHandoo commented 8 months ago

Hey @jortel As i am looking forward to work on this issue. I find myself stuck as i found the JSON type in model package like this. However, I couldn't find any reference to this type in the api package. Could you please provide some guidance or clarification on how to handle the JSON type in the api package? TLA!

jortel commented 5 months ago

Hey @RipulHandoo The JSON type defined in the model package is not (cannot be) used and a leftover from before the migration package was introduced. This issue has been moved back to the BACKLOG (from READY) for now. We need to put some more thought into this. As you can imagine, we're extremely cautious about changes to the model and REST resources at a core level.