search

koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

Add IPM.DistList test TNEF file for issue #74 #100

Closed RossPatterson closed 3 years ago

RossPatterson commented 3 years ago

Add IPM.DistList test TNEF file for issue #74 as requested by jrideout. The names and email addresses have been cleaned by hand, using a hex editor, to protect their owner's privacy, and the resulting file has been verified via tnefparse -o and tnefparse -d, and it still fails as described in the issue when processed by tnefparse -a

codecov[bot] commented 3 years ago

Codecov Report

Merging #100 (81bc3d4) into master (2888fab) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files           7        7           
  Lines        1285     1285           
  Branches      116      116           
=======================================
  Hits         1225     1225           
  Misses         41       41           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2888fab...81bc3d4. Read the comment docs.

jrideout commented 3 years ago

@RossPatterson Thanks for this. It turns out one of our existing fixtures has the same issue too.

The culprit is this line: https://github.com/koodaamo/tnefparse/blob/master/tnefparse/tnef.py#L129

I merged your commit into a new branch: https://github.com/koodaamo/tnefparse/pull/101, where I'll put the fix as well. That branch now also has a failing test case for your file.