koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

Unit test mapi attribute parsing #106

Closed jrideout closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #106 (49ef0a9) into master (c69dc45) will increase coverage by 1.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   96.18%   97.50%   +1.31%     
==========================================
  Files           7        7              
  Lines        1286     1283       -3     
  Branches      120      119       -1     
==========================================
+ Hits         1237     1251      +14     
+ Misses         34       25       -9     
+ Partials       15        7       -8     
Impacted Files Coverage Δ
tnefparse/cmdline.py 100.00% <100.00%> (ø)
tnefparse/mapi.py 90.90% <100.00%> (+9.58%) :arrow_up:
tnefparse/util.py 92.85% <0.00%> (+2.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c69dc45...49ef0a9. Read the comment docs.

jrideout commented 3 years ago

Running tests/test_attributes.py works just fine. But when run with the whole test suite we don't get any log output. I suspect https://github.com/koodaamo/tnefparse/blob/master/tnefparse/__init__.py#L5

jrideout commented 3 years ago

Interesting, I've isolated it to something in tests/test_cmdline.py and only when run as tox -e py38 -- -v tests/test_attributes.py tests/test_cmdline.py, running in the reverse order of tox -e py38 -- -v tests/test_cmdline.py tests/test_attributes.py passes

jrideout commented 3 years ago

Found it: https://github.com/koodaamo/tnefparse/blob/master/tnefparse/cmdline.py#L12 is the actual culprit here