koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

Parse all attribute level properties #38

Closed jrideout closed 5 years ago

jrideout commented 5 years ago

For our test set at least, all TNEFObject level attributes are now being parsed correctly. If these attributes are not otherwise used, they are placed in the msgprops attribute of the TNEF object.

I also have some cleanup mixed in (apologies):

codecov[bot] commented 5 years ago

Codecov Report

Merging #38 into master will increase coverage by 0.04%. The diff coverage is 90.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #38      +/-   ##
=========================================
+ Coverage   90.16%   90.2%   +0.04%     
=========================================
  Files           5       5              
  Lines         915     960      +45     
  Branches       84      93       +9     
=========================================
+ Hits          825     866      +41     
- Misses         67      69       +2     
- Partials       23      25       +2
Impacted Files Coverage Δ
tnefparse/util.py 75.75% <100%> (+2.32%) :arrow_up:
tnefparse/mapi.py 94.07% <85%> (+0.32%) :arrow_up:
tnefparse/tnef.py 89.33% <91.52%> (-1.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ae7cb7...92bda6e. Read the comment docs.

jrideout commented 5 years ago

@petri other than finishing up the few items in #26, this concludes all the short-term objectives I had. I have some ideas on refactoring, but nothing urgent.