search

koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

Should we rename PID_TAG_ constants? #44

Closed jrideout closed 5 years ago

jrideout commented 5 years ago

PidTag or PidLid are the naming conventions MS uses, so I used the same when adding a bunch of properties outside the core MAPI types.

I'm thinking though, we just call everything MAPI_ for consistency. We'll want to decide this before publishing 1.3.

petri commented 5 years ago

Stay consistent with the TNEF / MAPI docs (if feasible; I don't know if the docs themselves are consistent on this), and just add a comment pointing out that PidTag or PidLid are just MAPI types with a different naming convention?

Just a thought; no strong opinion either way.

jrideout commented 5 years ago

To stay consistent we'd want to rename the existing MAPI_* types to PIDTAG, which would probably break existing applications. Given that, I'm going to just convert it all to MAPI and then add a comment like you suggest.

jrideout commented 5 years ago

Changes in #45

petri commented 5 years ago

To stay consistent we'd want to rename the existing MAPI_* types to PID_TAG, which would probably break existing applications.

I see. We can consider doing that in a controlled manner over a timespan of a few releases at some later time I guess.