search

koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

fixes & enhancements in parsing #6

Closed emdete closed 5 years ago

emdete commented 10 years ago

i added the parsing of datatypes in tnef and fixed some bugs in tnef parsing

petri commented 7 years ago

Thank you for the pull request. My apologies for not handling the PR in due time.

However, the PR is quite large. I would like to handle the different kinds of changes you're proposing in different PRs. Would that be ok?

With that in mind, could you first make a separate PR against the current master, for the parsing of datatypes? Same goes for bugs that you have found. I will try & merge those ASAP.

I am not against beautifying the API & optimizations etc. but would like to handle those separately.

emdete commented 7 years ago

as some patches depend on each other it will be difficult... i would suggest to take it as is to prevent unessesary work (time is short). if in doubt just use cherrypick to take the changes that you want.

petri commented 5 years ago

@jrideout are there any improvements here that you'd be interested in taking a look at? Taking a look at the list of commits above, I am thinking especially e1a6340, d3c6ebc, 6c91519 and 6fb7579 that promise fixes and enhancements.

jrideout commented 5 years ago

@petri After #38, I think we accounted for all the changes in this PR