koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

update supported python versions #79

Closed jugmac00 closed 3 years ago

jugmac00 commented 3 years ago

Drop Python 2 compatibility code Drop support for Python 3.5 Add support for Python 3.9 Apply pyupgrade on code base to modernize syntax

fixes #75 fixes #80

codecov[bot] commented 3 years ago

Codecov Report

Merging #79 (be05052) into master (d2ccc68) will increase coverage by 0.75%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   92.14%   92.90%   +0.75%     
==========================================
  Files           7        7              
  Lines        1311     1296      -15     
  Branches      121      117       -4     
==========================================
- Hits         1208     1204       -4     
+ Misses         78       70       -8     
+ Partials       25       22       -3     
Impacted Files Coverage Δ
tnefparse/tnef.py 92.06% <85.71%> (ø)
tnefparse/codepage.py 80.00% <100.00%> (ø)
tnefparse/mapi.py 80.00% <100.00%> (+0.83%) :arrow_up:
tnefparse/util.py 66.66% <100.00%> (+6.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2ccc68...be05052. Read the comment docs.

jugmac00 commented 3 years ago

I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ...

I see no problem with this PR.

petri commented 3 years ago

I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ...

I see no problem with this PR.

Seems to me it complains because the tests do not cover enough (92.14%) of the "new code that's added" (despite overall improved coverage). But I'm fine being a bit more relaxed in this case.