Closed jugmac00 closed 3 years ago
Merging #79 (be05052) into master (d2ccc68) will increase coverage by
0.75%
. The diff coverage is90.00%
.
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 92.14% 92.90% +0.75%
==========================================
Files 7 7
Lines 1311 1296 -15
Branches 121 117 -4
==========================================
- Hits 1208 1204 -4
+ Misses 78 70 -8
+ Partials 25 22 -3
Impacted Files | Coverage Δ | |
---|---|---|
tnefparse/tnef.py | 92.06% <85.71%> (ø) |
|
tnefparse/codepage.py | 80.00% <100.00%> (ø) |
|
tnefparse/mapi.py | 80.00% <100.00%> (+0.83%) |
:arrow_up: |
tnefparse/util.py | 66.66% <100.00%> (+6.94%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d2ccc68...be05052. Read the comment docs.
I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ...
I see no problem with this PR.
I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ...
I see no problem with this PR.
Seems to me it complains because the tests do not cover enough (92.14%) of the "new code that's added" (despite overall improved coverage). But I'm fine being a bit more relaxed in this case.
Drop Python 2 compatibility code Drop support for Python 3.5 Add support for Python 3.9 Apply
pyupgrade
on code base to modernize syntaxfixes #75 fixes #80