Closed eumiro closed 3 years ago
Merging #84 (c4dd126) into master (f81554d) will increase coverage by
0.23%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 95.09% 95.33% +0.23%
==========================================
Files 7 7
Lines 1284 1285 +1
Branches 115 116 +1
==========================================
+ Hits 1221 1225 +4
+ Misses 43 41 -2
+ Partials 20 19 -1
Impacted Files | Coverage Δ | |
---|---|---|
tnefparse/cmdline.py | 100.00% <100.00%> (+3.75%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f81554d...c4dd126. Read the comment docs.
Please rebase/merge master once #93 is merged.
Ok, this looks good now!
Thanks for your patience.
There is one last thing...
Could you please add a docstring to both test_cmdline_logging_info
and test_cmdline_logging_warn
where you explain what the test is doing?
For reference, I like this short blog post on how to write good docstrings for tests: https://jml.io/pages/test-docstrings.html
Thanks a lot!
The deed is done.
No need to use
eval
here.