Closed eumiro closed 3 years ago
Merging #85 (c6abdf0) into master (34f0ba2) will increase coverage by
0.14%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 93.05% 93.19% +0.14%
==========================================
Files 7 7
Lines 1296 1294 -2
Branches 117 117
==========================================
Hits 1206 1206
+ Misses 68 66 -2
Partials 22 22
Impacted Files | Coverage Δ | |
---|---|---|
tnefparse/mapi.py | 80.98% <0.00%> (+0.98%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 34f0ba2...c6abdf0. Read the comment docs.
1. The exception handler does nothing by default, since `logger.exception` logs at DEBUG level, and tnefparse root logging level is ERROR
logger.exception
logs at ERROR
level. This is what I could find in its source code.
2. User is no longer able to get just the one-liner error message at the default ERROR level and then optionally more (the trace) with DEBUG
A single logger.exception
would not meet this requirement, so I changed it to two calls, one ERROR
like before and one DEBUG
with exc_info=True
.
1. The exception handler does nothing by default, since `logger.exception` logs at DEBUG level, and tnefparse root logging level is ERROR
logger.exception
logs atERROR
level. This is what I could find in its source code.
Huh. Doublechecked, you're right. My mistake, sorry about that. Looks all good to me now, thanks!
Call
logging.exception
method to get the custom message and stack trace in one call.