search

koodaamo / tnefparse

a TNEF decoding library written in python, without external dependencies
GNU Lesser General Public License v3.0
49 stars 37 forks source link

Use f-strings #87

Closed eumiro closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #87 (80887f4) into master (f81554d) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files           7        7           
  Lines        1284     1284           
  Branches      115      115           
=======================================
  Hits         1221     1221           
  Misses         43       43           
  Partials       20       20
Impacted Files Coverage Δ
tnefparse/mapi.py 80.98% <0.00%> (ø)
tnefparse/tnef.py 92.83% <33.33%> (ø)
tnefparse/codepage.py 80.95% <50.00%> (ø)
tnefparse/cmdline.py 96.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f81554d...80887f4. Read the comment docs.

jugmac00 commented 3 years ago

Thanks for your contribution!

We had a short discussion about the usage of f-strings in https://github.com/koodaamo/tnefparse/pull/79#discussion_r528839782 and as @petri merged the PR (with added f-strings), I think there is a consensus now to go with f-strings :-)

Quite some lines you changed are currently without coverage.

It would be awesome to add the missing coverage with this PR.

And also, as @petri suggested in another issue, please add a change log entry.