codecov[bot] commented 3 years ago

Codecov Report

Merging #89 (509e32b) into master (9a0d8df) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   96.20%   96.18%   -0.02%     
==========================================
  Files           7        7              
  Lines        1290     1286       -4     
  Branches      120      120              
==========================================
- Hits         1241     1237       -4     
  Misses         34       34              
  Partials       15       15

Impacted Files	Coverage Δ
tnefparse/cmdline.py	`100.00% <100.00%> (ø)`
tnefparse/tnef.py	`95.25% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a0d8df...509e32b. Read the comment docs.

petri commented 3 years ago

By the way, please can you include changelog entries into HISTORY.rst in PRs so that you get proper credit for your work?

jrideout commented 3 years ago

@eumiro Would you mind rebasing and fixing this PR now that we've made some conflicting changes (including merging your other PRs) ?

eumiro commented 3 years ago

Yes, @jrideout. The problem was Python 3.9's new method with_stem which I could replace with with_name.

Now I reviewed and reworked the whole PR and added tmp_path fixtures that provide a pathlib.Path in a central temporary directory structure.

jrideout commented 3 years ago

@eumiro Can you please rebase once more?

eumiro commented 3 years ago

@jrideout done

koodaamo / tnefparse

Replace os.path.* with pathlib #89

Codecov Report