search

kookma / TW-Shiraz

Shiraz is a small Tiddlywiki 5 plugin contains macros, stylesheets, templates, snippets, images, static tables, dynamic tables and acts as a starter kit.
https://kookma.github.io/TW-Shiraz/
78 stars 8 forks source link

Expand stylesheets to cover th header cells #1

Closed dnebauer closed 5 years ago

dnebauer commented 5 years ago

The macros in $:/plugins/.mr/shiraz/stylesheet/tables style only header cells tagged with thead > td, e.g.,

.thead-orange thead td{background-color: #FFA500; color: #ffffff;}

This is perfectly correct for the output from TW tables using header rows, e.g.,

| Header 1 |  Header 2 |h

I, however, wrote a macro which generated tables with header cells tagged with thead > th. When I attempted to style them with Shiraz stylesheets, the headers did not style correctly. I fixed the problem by altering the macro to use td tags for header cells.

If you extend your stylesheets to also support header cells which use th tags, it will improve the usability of your plugin for those producing tables from custom macros.

If you're okay with this change, I'm willing to do a pull request to implement it.

kookma commented 5 years ago

@dnebauer Yes, please do it! Of course a new major release will be up in mid April 2019. So, I appreciate to have your solution.

kookma commented 5 years ago

Implemented!