Unable to compile gperftools on Windows using Visual Studio solution

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Download gperftools.
2. Open the visual studio solution using say Visual Studio 2013.
3. Try to build solution.

What is the expected output? What do you see instead?
Expected output is that the projects compile successfully. Instead, I see lots 
of compile errors.

What version of the product are you using? On what operating system?
The latest source as of this writing. Windows 8.1.

Please provide any additional information below.
The sources files I see under the visual studio solution is different from the 
the source files listed online under Source/Browse.

Original issue reported on code.google.com by krishna....@gmail.com on 23 Mar 2014 at 4:54

[GoogleCodeExporter]

I don't have windows 8.1 but on my windows 7 VM compilation on MSVC 2013 
express edition works.

I need more details from you:

* please elaborate a bit more on "the latest source as of this writing". Is 
that from git ?

* Do you see same issue on other than windows 8.1 release

* Can you please elaborate on compile errors you're seeing?

Original comment by alkondratenko on 24 Mar 2014 at 5:37

[GoogleCodeExporter]

Thanks for your response and sorry for the delay in circling back to you. Here 
are the additional details that you requested:

1) Yes. It was from git. I obtained the latest source using the following 
command: "git clone https://code.google.com/p/gperftools/" on my Windows 8.1 
system.

2) I haven't tried this on other Windows systems.

3) I have attached the build log (build_errors.txt) for your reference.

Original comment by krishna....@gmail.com on 27 Mar 2014 at 6:27

Attachments:

• build_errors.txt

[GoogleCodeExporter]

Hm. That std::min was fixed relatively recently.

May I ask you show me output of git describe ?

Original comment by alkondratenko on 27 Mar 2014 at 4:14

[GoogleCodeExporter]

What is git describe? Sorry I am not familiar with git stuff.

Original comment by krishna....@gmail.com on 28 Mar 2014 at 2:28

[GoogleCodeExporter]

In same directory where you did git clone, do "git describe" via command line 
and post it's output here.

Original comment by alkondratenko on 28 Mar 2014 at 10:52

[GoogleCodeExporter]

>git describe --always
fe56631

Original comment by krishna....@gmail.com on 29 Mar 2014 at 5:42

[GoogleCodeExporter]

Indeed. There was missing include. Thanks for reporting it.

Either I didn't test on VS2013 recently, or VS2013 update 1 is now not 
automatically including std::min in whatever system-alloc.cc was including.

Fix is merged now.

Original comment by alkondratenko on 29 Mar 2014 at 8:27

• Changed state: Fixed