search

koolhazz / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Env var to enable cpu profile should be "CPUPROFILE" in profile.h head desc #630

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
The guide desc in the file(src/gperftools/profile.h) is not consistent with the 
code implementation. To enable cpu profile, the env var should be "CPUPROFILE", 
not "PROFILE" actually.

What is the expected output? What do you see instead?
"PROFILE" should be "CPUPROFILE"

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by zhsBer...@gmail.com on 26 Jun 2014 at 2:39

GoogleCodeExporter commented 9 years ago 
Copy from chromium issue:

http://code.google.com/p/chromium/issues/detail?id=384763

Original comment by zhsBer...@gmail.com on 26 Jun 2014 at 2:45

GoogleCodeExporter commented 9 years ago 
Thanks. Willing to send patch maybe ?

Original comment by alkondratenko on 26 Jun 2014 at 4:40

GoogleCodeExporter commented 9 years ago 
It's my pleasure. 
But i didn't find how to contribute, maybe need some access permission?

Original comment by zhsBer...@gmail.com on 27 Jun 2014 at 5:28

GoogleCodeExporter commented 9 years ago 
You can do it by fixing it in your git repository. The committing it local with 
good commit message. Then attaching patch. One way that I do is:

# git format-patch HEAD^

which will create "git am" applicable patch from your last commit.

I'm going leave it open for some time and give you time to prepare a patch and 
"score" contribution. I.e. because this issue is not something that I have to 
fix super-urgently.

Let me know if you are not going to do it. In which case I'll fix it myself and 
mention your contribution in commit message.

Original comment by alkondratenko on 28 Jun 2014 at 8:14

GoogleCodeExporter commented 9 years ago 
I'll fix it and attach the patch here as soon as possible.

Original comment by zhsBer...@gmail.com on 30 Jun 2014 at 2:35

GoogleCodeExporter commented 9 years ago 
Sorry for late. 
Here is the patch. Please check.

Original comment by zhsBer...@gmail.com on 5 Jul 2014 at 12:52

Attachments:

GoogleCodeExporter commented 9 years ago 
applied. Thanks.

Original comment by alkondratenko on 7 Jul 2014 at 1:54