kooloveme / thtmlviewer

Automatically exported from code.google.com/p/thtmlviewer
Other
0 stars 0 forks source link

Incorrect min/max section width calculations #168

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which steps will reproduce the problem?
The problem is not reliably reproducible in the wild.  Can simulate the problem 
by initializing SoftHyphen to true in TSection.MinMaxWidth.  See more info at 
the bottom.

What is the expected output? What do you see instead?
A div (X) with a fixed-width contains:
* A div with no specific width containing an image (Y)
* A div (Z) with a fixed width containing some text
...such that width(X) = width(Y) + width(Z). All divs are set to float left.
The expected rendering is with the text floated to the right of, and 
top-aligned to, the image.  Sometimes, however, the text appears directly below 
the image.

Which version of the product are you using? Which compiler version are you
using? On which operating system?
Using v11 on Delphi XE, Windows 7 x64.

Please attach test html files and screenshots, if appropriate.
Please provide any additional information:
This appears to be due to a bug in TSection.MinMaxWidth where SoftHyphen is not 
explicitly set before being used by FindTextWidthB (when setting Max 
immediately prior to the wrapping logic).  I believe this variable is only 
required when performing the wrapping logic and so should be initialized to 
false at the beginning of this method.

Original issue reported on code.google.com by sean.fer...@gmail.com on 3 Jul 2012 at 6:00

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for looking into this issue, Sean.

r312 fixes it.

Original comment by OrphanCat on 18 Jul 2012 at 8:43