kooloveme / thtmlviewer

Automatically exported from code.google.com/p/thtmlviewer
Other
0 stars 0 forks source link

Full URL not passed to Click handler #219

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which steps will reproduce the problem?
1. Open a demo app with TFrameBrowser (eg. I used "FrameBrowserUsingIndy9")
2. Create OnHotSpotTargetClick event if not defined
3. Breakpoint to inspect URL string passed in

What is the expected output? 
Expect to see full URL. eg. res://page1.htm

What do you see instead?
Raw href link from source file. eg. page1.htm

Which version of the product are you using?
SVN download as of Nov 26, 2012

Which compiler version are you using?  XE3

On which operating system? Windows 7

Please attach test html files and screenshots, if appropriate.
Please provide any additional information:

Simple problem: Typo identified in FramView.pas
"FullUrl" parameter not passed to event handler

function TFVBase.HotSpotClickHandled(const FullUrl: ThtString): boolean;
begin
  Result := False;
  if Assigned(OnHotSpotTargetClick) then
    OnHotSpotTargetClick(Self, FTarget, FURL, Result);  <=== REMOVE
    OnHotSpotTargetClick(Self, FTarget, FullUrl, Result); <=== REPLACE WITH
end;

NOTES
1) Earlier Thtmlviewer code from PBear had correct parameter (FullUrl), so 
problem has been introduced
2) Demos do work as is, because they are not adversely affected by missing 
protocol

Original issue reported on code.google.com by i...@discoverysystems.com.au on 29 Nov 2012 at 2:27

GoogleCodeExporter commented 9 years ago
Thanks for spotting and solving this issue!

r347 fixes it in the repository.

Original comment by OrphanCat on 25 Jan 2013 at 10:23