koolphp / koolreport

This is an Open Source PHP Reporting Framework which you can use to write perfect data reports or to construct awesome dashboards using PHP
https://www.koolreport.com/
MIT License
226 stars 66 forks source link

3.25.1: PHP Warning: count(): Parameter must be an array or an object that implements Countable in vendor/koolphp/koolreport/src/widgets/koolphp/Table.php on line 410 #22

Closed lkraav closed 5 years ago

lkraav commented 5 years ago

Post-upgrade, our DrillDown chart started throwing this notice.

Are you guys testing releases on PHP 7.2+?

https://github.com/koolphp/koolreport/blob/v3.25.1/src/widgets/koolphp/Table.php#L410 should probably be

if ($this->group && count($this->group) === 0 && count($this->sorting)>0) {}
koolphp commented 5 years ago

Please upgrade to 3.25.3, the issue has been fixed.